feat: generation of searchbnf.conf#1695
Merged
hetangmodi-crest merged 6 commits intofeat/add-validations-for-cscfrom May 9, 2025
Merged
feat: generation of searchbnf.conf#1695hetangmodi-crest merged 6 commits intofeat/add-validations-for-cscfrom
searchbnf.conf#1695hetangmodi-crest merged 6 commits intofeat/add-validations-for-cscfrom
Conversation
13 tasks
This was referenced Apr 16, 2025
kkedziak-splunk
approved these changes
Apr 17, 2025
splunk_add_on_ucc_framework/generators/conf_files/create_searchbnf_conf.py
Outdated
Show resolved
Hide resolved
| ucc_dir=ucc_dir, | ||
| addon_name=ta_name, | ||
| ) | ||
| assert searchbnf_conf.searchbnf_info == [] |
Contributor
There was a problem hiding this comment.
I like the last test but TBH I am not sure a test like that is needed. I mean, the last test probably covers the whole class and on the other hand a test like this one here, will fail when the parameter is renamed
Contributor
Author
There was a problem hiding this comment.
In case when the searchAssistant isn't provided in globalConfig, we wouldn't be able to test for the file content as it won't be present as the file itself wouldn't be created, and hence, in the test case, I didn't make the generate() call as we know the file won't be generated. I'll take it up in the other PR for updating tests.
hetangmodi-crest
merged commit 863d5a0
into
feat/add-validations-for-csc
92 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: ADDON-76780
PR Type
What kind of change does this PR introduce?
Summary
Changes
This PR includes the generation of the
searchbnf.conffile for the custom search command.User experience
After defining a valid configuration for the custom search command in
globalConfig.json, thesearchbnf.conffile will be generated.Checklist
If an item doesn't apply to your changes, leave it unchecked.
Review
Tests
See the testing doc.
Demo/meeting:
Reviewers are encouraged to request meetings or demos if any part of the change is unclear